diff --git a/podctl/visitors/packages.py b/podctl/visitors/packages.py index a62eb50..4b38eb2 100644 --- a/podctl/visitors/packages.py +++ b/podctl/visitors/packages.py @@ -24,7 +24,7 @@ class Packages: self.packages = list(packages) self.mgr = None - def init_build(self, script): + def pre_build(self, script): base = script.container.variable('base') for mgr, cmds in self.mgrs.items(): cmd = ['podman', 'run', base, 'sh', '-c', f'type {mgr}'] diff --git a/tests/test_build_copy.sh b/tests/test_build_copy.sh index ee9fa08..d0f4556 100644 --- a/tests/test_build_copy.sh +++ b/tests/test_build_copy.sh @@ -1,18 +1,15 @@ #/usr/bin/env bash base="alpine" repo="None" -tag="None" -image="None" mounts=() umounts() { for i in "${mounts[@]}"; do umount $i - echo $mounts mounts=("${mounts[@]/$i}") - echo $mounts done + buildah unmount $ctr + trap - 0 } trap umounts 0 ctr=$(buildah from $base) -mnt=$(buildah mount $ctr) -mounts=("$mnt" "${mounts[@]}") \ No newline at end of file +mnt=$(buildah mount $ctr) \ No newline at end of file diff --git a/tests/test_build_empty.sh b/tests/test_build_empty.sh index ee9fa08..d0f4556 100644 --- a/tests/test_build_empty.sh +++ b/tests/test_build_empty.sh @@ -1,18 +1,15 @@ #/usr/bin/env bash base="alpine" repo="None" -tag="None" -image="None" mounts=() umounts() { for i in "${mounts[@]}"; do umount $i - echo $mounts mounts=("${mounts[@]/$i}") - echo $mounts done + buildah unmount $ctr + trap - 0 } trap umounts 0 ctr=$(buildah from $base) -mnt=$(buildah mount $ctr) -mounts=("$mnt" "${mounts[@]}") \ No newline at end of file +mnt=$(buildah mount $ctr) \ No newline at end of file diff --git a/tests/test_build_packages.sh b/tests/test_build_packages.sh index 194501f..0350824 100644 --- a/tests/test_build_packages.sh +++ b/tests/test_build_packages.sh @@ -1,25 +1,21 @@ #/usr/bin/env bash base="alpine" repo="None" -tag="None" -image="None" mounts=() umounts() { for i in "${mounts[@]}"; do umount $i - echo $mounts mounts=("${mounts[@]/$i}") - echo $mounts done + buildah unmount $ctr + trap - 0 } trap umounts 0 ctr=$(buildah from $base) mnt=$(buildah mount $ctr) -mounts=("$mnt" "${mounts[@]}") buildah run --user root $ctr -- mkdir -p /var/cache/apk mkdir -p $(pwd)/.cache/apk mount -o bind $(pwd)/.cache/apk $mnt/var/cache/apk -mounts=("$mnt/var/cache/apk" "${mounts[@]}") buildah run $ctr -- ln -s /var/cache/apk /etc/apk/cache old="$(find .cache/apk/ -name APKINDEX.* -mtime +3)" if [ -n "$old" ] || ! ls .cache/apk/APKINDEX.*; then diff --git a/tests/test_build_user.sh b/tests/test_build_user.sh index 8bebad4..f7ee9f9 100644 --- a/tests/test_build_user.sh +++ b/tests/test_build_user.sh @@ -1,25 +1,21 @@ #/usr/bin/env bash base="alpine" repo="None" -tag="None" -image="None" mounts=() umounts() { for i in "${mounts[@]}"; do umount $i - echo $mounts mounts=("${mounts[@]/$i}") - echo $mounts done + buildah unmount $ctr + trap - 0 } trap umounts 0 ctr=$(buildah from $base) mnt=$(buildah mount $ctr) -mounts=("$mnt" "${mounts[@]}") buildah run --user root $ctr -- mkdir -p /var/cache/apk mkdir -p $(pwd)/.cache/apk mount -o bind $(pwd)/.cache/apk $mnt/var/cache/apk -mounts=("$mnt/var/cache/apk" "${mounts[@]}") buildah run $ctr -- ln -s /var/cache/apk /etc/apk/cache old="$(find .cache/apk/ -name APKINDEX.* -mtime +3)" if [ -n "$old" ] || ! ls .cache/apk/APKINDEX.*; then